Overhaul Formula/Cask JSON generation #14615
Conversation
MikeMcQuaid
added
the
critical
|
Review period skipped due to |
See Homebrew/brew#14615 This will set placeholder values in the generated hash.
MikeMcQuaid
force-pushed
the
generating_hash_appdir
branch
from
39b1f27
to
074490f
Compare
There was a problem hiding this comment.
Fantastic, thanks! Good we managed to get this in for 4.0.0 as I initially thought it might've been too late.
I think this covers the last of the known cask issues, which is excellent news.
The slight snag to be aware of is we might be breaking people until their next auto-update if we're generating the JSON with the new placeholders right away (same scenario as #14611).
There was a problem hiding this comment.
In general, I think this is a good idea. A few thoughts...
I wonder what the performance implications are for this when calling brew info --json=v2 --eval-all though that's not something we need to necessarily figure out now.
It would be nice to see some regression tests here.
And like @Bo98 I'm a bit confused about this only being enabled by default in Cask#to_h when we use Cask#to_hash_with_variations to generate the API json.
MikeMcQuaid
force-pushed
the
generating_hash_appdir
branch
from
074490f
to
7a192f6
Compare
Added.
Removed from both, will put only in Homebrew/formulae.brew.sh#744 instead. |
MikeMcQuaid
force-pushed
the
generating_hash_appdir
branch
from
7a192f6
to
7b5c338
Compare
- Use constants for placeholders - Monkeypatch to set `HOMEBREW_PREFIX` consistently to placeholder - Use environment variable to set `Dir.home` consistently to placeholder - Use `appdir` short-circuit to set `Cask#appdir` consistently to placeholder - Use `Cask.generating_hash!` to enable "generating mode" with these patches - Fix `Formula#caveats` from JSON Fixes #14505 Fixes #14595
MikeMcQuaid
force-pushed
the
generating_hash_appdir
branch
from
7b5c338
to
237eec8
Compare
See Homebrew/brew#14615 This will set placeholder values in the generated hash.
See Homebrew/brew#14615 This will set placeholder values in the generated hash.
There was a problem hiding this comment.
Thanks, @MikeMcQuaid! This looks great, sorry for the review delay!
See Homebrew/brew#14615 This will set placeholder values in the generated hash.
Take a slightly hackier but more reliable method of setting up
$HOMEBREW_PREFIX,$HOMEand--appdir.HOMEBREW_PREFIXconsistently to placeholderDir.homeconsistently to placeholderappdirshort-circuit to setCask#appdirconsistently to placeholderCask.generating_hash!to enable "generating mode" with these patchesFormula#caveatsfrom JSONSee Homebrew/formulae.brew.sh#744 for the formulae.brew.sh side.
Fixes #14505
Fixes #14595