Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd/update-reset: improve arg parsing #14667

Merged
merged 4 commits into from Feb 28, 2023

Commits on Feb 16, 2023

  1. cmd/update-reset: accept tap names as arguments

    Currently, doing `brew update-reset homebrew/core` does nothing (not
    even return an error). If you want to `update-reset` a given tap, you
    must do (the equivalent of)
    
        brew update-reset "$(brew --repository owner/tap_name)"
    
    This isn't very intuitive, so let's do a bit more work in argument
    parsing so that the user can just pass a tap name instead of a path to a
    tap.
    
    Passing a path to a tap is also still supported.
    carlocab committed Feb 16, 2023
    Configuration menu
    Copy the full SHA
    ac7dbc0 View commit details
    Browse the repository at this point in the history

Commits on Feb 28, 2023

  1. Revert "cmd/update-reset: accept tap names as arguments"

    This reverts commit ac7dbc0.
    carlocab committed Feb 28, 2023
    Configuration menu
    Copy the full SHA
    12364d7 View commit details
    Browse the repository at this point in the history
  2. cmd/update-reset: improve arg validation

    This is based on feedback from Homebrew#14667.
    carlocab committed Feb 28, 2023
    Configuration menu
    Copy the full SHA
    53053e0 View commit details
    Browse the repository at this point in the history
  3. workflows/tests: avoid resetting homebrew/bundle

    This command was being called with the wrong relative path, so it
    silently did nothing. Now that `update-reset` errors out from invalid
    arguments, we know that running `update-reset` here is not needed.
    carlocab committed Feb 28, 2023
    Configuration menu
    Copy the full SHA
    e2082f0 View commit details
    Browse the repository at this point in the history