Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bash completions: warn and exit if POSIX mode detected #14669

Merged
merged 1 commit into from Feb 16, 2023

Conversation

maxim-belkin
Copy link
Member

@maxim-belkin maxim-belkin commented Feb 16, 2023

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally?

Bash completions: test if POSIX mode is enabled, print an error message and exit out.
Fixes #14643

The check itself is written in POSIX-compliant manner.
The message is written to standard error.
I think this check shouldn't return a non-zero exit code, but I'm open to suggestions / opinions.

@BrewTestBot
Copy link
Member

Review period will end on 2023-02-17 at 16:15:37 UTC.

@BrewTestBot BrewTestBot added the waiting for feedback Merging is blocked until sufficient time has passed for review label Feb 16, 2023
@MikeMcQuaid MikeMcQuaid added the critical Critical change which should be shipped as soon as possible. label Feb 16, 2023
@BrewTestBot BrewTestBot removed the waiting for feedback Merging is blocked until sufficient time has passed for review label Feb 16, 2023
@BrewTestBot
Copy link
Member

Review period skipped due to critical label.

@MikeMcQuaid
Copy link
Member

Makes sense to me, thanks again @maxim-belkin!

@MikeMcQuaid MikeMcQuaid merged commit 0640cdc into Homebrew:master Feb 16, 2023
@maxim-belkin maxim-belkin deleted the completions-no-posix branch February 16, 2023 16:59
@github-actions github-actions bot added the outdated PR was locked due to age label Mar 19, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
critical Critical change which should be shipped as soon as possible. outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

brew bash competion error line 27
3 participants