Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cask: add FromAPILoader tests #14678

Merged
merged 1 commit into from Feb 17, 2023
Merged

cask: add FromAPILoader tests #14678

merged 1 commit into from Feb 17, 2023

Conversation

apainintheneck
Copy link
Contributor

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally?

Just thought it'd be nice to have some basic tests here since we're now all in on the API. I wrote it up in such a way that doesn't need the network either.

@apainintheneck apainintheneck added the cask Homebrew Cask label Feb 17, 2023
@BrewTestBot
Copy link
Member

Review period will end on 2023-02-20 at 03:42:46 UTC.

@BrewTestBot BrewTestBot added the waiting for feedback Merging is blocked until sufficient time has passed for review label Feb 17, 2023
@MikeMcQuaid MikeMcQuaid added the critical Critical change which should be shipped as soon as possible. label Feb 17, 2023
MikeMcQuaid
MikeMcQuaid approved these changes Feb 17, 2023
View reviewed changes
Copy link
Member

@MikeMcQuaid MikeMcQuaid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work, thanks for this @apainintheneck!

@BrewTestBot BrewTestBot removed the waiting for feedback Merging is blocked until sufficient time has passed for review label Feb 17, 2023
@BrewTestBot
Copy link
Member

Review period skipped due to critical label.

@MikeMcQuaid MikeMcQuaid merged commit 897121d into Homebrew:master Feb 17, 2023
@MikeMcQuaid MikeMcQuaid added critical Critical change which should be shipped as soon as possible. and removed critical Critical change which should be shipped as soon as possible. labels Feb 17, 2023
@github-actions github-actions bot added the outdated PR was locked due to age label Mar 20, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 20, 2023
@apainintheneck apainintheneck deleted the add-cask-api-loader-tests branch March 24, 2023 03:25
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@MikeMcQuaid MikeMcQuaid MikeMcQuaid approved these changes

@BrewTestBot BrewTestBot BrewTestBot approved these changes

Assignees
No one assigned
Labels
cask Homebrew Cask critical Critical change which should be shipped as soon as possible. outdated PR was locked due to age
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@apainintheneck @BrewTestBot @MikeMcQuaid