Warn more when building from source #14686
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review period will end on 2023-02-20 at 14:24:07 UTC. |
BrewTestBot
added
the
waiting for feedback
Bo98
reviewed
Feb 17, 2023
MikeMcQuaid
force-pushed
the
build_from_source_warnings
branch
from
95c5a47
to
012ad51
Compare
Bo98
approved these changes
Feb 17, 2023
We warn sometimes when we tell people to build from source and it's not supported but we don't actually warn non-developers when invoking the various install commands so: let's start doing so. While we're here, also update the existing messaging to reflect the fact we're on Mastodon now too and we don't want maintainers being individually bothered about errors either. I've tried to balance having messages here vs. having them be so long at the beginning of installation that they will be missed or be overly obnoxious.
MikeMcQuaid
force-pushed
the
build_from_source_warnings
branch
from
012ad51
to
fbdec87
Compare
carlocab
approved these changes
Feb 18, 2023
MikeMcQuaid
added
the
critical
BrewTestBot
removed
the
waiting for feedback
|
Review period skipped due to |
BrewTestBot
approved these changes
Feb 20, 2023
|
Two ✅ so making critical to get into 4.0.2. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We warn sometimes when we tell people to build from source and it's not supported but we don't actually warn non-developers when invoking the various install commands so: let's start doing so.
While we're here, also update the existing messaging to reflect the fact we're on Mastodon now too and we don't want maintainers being individually bothered about errors either.
I've tried to balance having messages here vs. having them be so long at the beginning of installation that they will be missed or be overly obnoxious.
Feedback welcome!