Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

More tweaks to testing output and speed #14691

Merged
merged 1 commit into from Feb 17, 2023
Merged

More tweaks to testing output and speed #14691

merged 1 commit into from Feb 17, 2023

Conversation

MikeMcQuaid
Copy link
Member

  • Never bother to do brew cleanup after brew install
  • Skip brew test-bot --only-cleanup-before in more places it's not needed
  • Move brew config/brew doctor into the default formula run (through brew test-bot --only-setup)
  • Install buildpulse-test-reporter rather than letting brew tests do it
  • Improve the formatting of the brew tests step
  • Further shorten the code coverage filenames
  • Don't output BuildPulse results upload status unless failed

@MikeMcQuaid
More tweaks to testing output and speed
80232af 
- Never bother to do `brew cleanup` after `brew install`
- Skip `brew test-bot --only-cleanup-before` in more places it's not
  needed
- Move `brew config`/`brew doctor` into the default formula run
  (through `brew test-bot --only-setup`)
- Install `buildpulse-test-reporter` rather than letting `brew tests`
  do it
- Improve the formatting of the `brew tests` step
- Further shorten the code coverage filenames
- Don't output BuildPulse results upload status unless failed
@MikeMcQuaid MikeMcQuaid added the critical Critical change which should be shipped as soon as possible. label Feb 17, 2023
@BrewTestBot
Copy link
Member

Review period skipped due to critical label.

@MikeMcQuaid MikeMcQuaid merged commit f08ed66 into Homebrew:master Feb 17, 2023
@MikeMcQuaid MikeMcQuaid deleted the more_nicer_tests branch February 17, 2023 16:55
@github-actions github-actions bot added the outdated PR was locked due to age label Mar 20, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 20, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@BrewTestBot BrewTestBot BrewTestBot approved these changes

Assignees
No one assigned
Labels
critical Critical change which should be shipped as soon as possible. outdated PR was locked due to age
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@MikeMcQuaid @BrewTestBot