Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support link_overwrite and conflicts_with in API #14725

Merged
merged 1 commit into from Feb 20, 2023
Merged

Support link_overwrite and conflicts_with in API #14725

merged 1 commit into from Feb 20, 2023

Conversation

Bo98
Copy link
Member

@Bo98 Bo98 commented Feb 20, 2023

Fixes #14721.

@Bo98 Bo98 added the critical Critical change which should be shipped as soon as possible. label Feb 20, 2023
@BrewTestBot
Copy link
Member

Review period skipped due to critical label.

MikeMcQuaid
MikeMcQuaid approved these changes Feb 20, 2023
View reviewed changes
Copy link
Member

@MikeMcQuaid MikeMcQuaid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work, thanks again @Bo98.

@MikeMcQuaid MikeMcQuaid merged commit ddd328e into Homebrew:master Feb 20, 2023
@Bo98 Bo98 deleted the api-link_overwrite branch February 20, 2023 16:45
@github-actions github-actions bot added the outdated PR was locked due to age label Mar 23, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@MikeMcQuaid MikeMcQuaid MikeMcQuaid approved these changes

@BrewTestBot BrewTestBot BrewTestBot approved these changes

@carlocab carlocab carlocab approved these changes

Assignees
No one assigned
Labels
critical Critical change which should be shipped as soon as possible. outdated PR was locked due to age
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

API installs do not respect link_overwrite
4 participants
@Bo98 @BrewTestBot @MikeMcQuaid @carlocab