Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

dev-cmd/contributions: Use GitHub APIs for commit author info #14737

Merged
merged 3 commits into from Feb 22, 2023

Commits on Feb 20, 2023

  1. dev-cmd/contributions: Use GitHub APIs for commit author info

    - Using `git log` was brittle with name changes and email address changes for
      contributors over the years unless we made a Git `mailmap` file which brings
      with it its own updatedness overhead.
    - Let's use the GitHub commits API (importantly _not_ the search API) so that
      we can give it a username and it will return contributions associated with
      every email address on that user's account:
      https://docs.github.com/en/rest/commits/commits?apiVersion=2022-11-28#list-commits--parameters.
    - This is quite significantly slower, but it's worth it for correctness
      especially when we get to all maintainers' contributions (in a separate PR).
    - The commits API does not (yet?) support trailers or commit "committer"s, just
      authors.
    issyl0 committed Feb 20, 2023
    Copy the full SHA
    d3827b1 View commit details
    Browse the repository at this point in the history

Commits on Feb 21, 2023

  1. Copy the full SHA
    0a6c59c View commit details
    Browse the repository at this point in the history
  2. utils/github: API.paginate_rest handles extra query params

    - Functionally it doesn't matter that the URL will have an `&` at the
      end if `additional_query_params` is `nil`, because it doesn't affect
      the URL at all.
    issyl0 committed Feb 21, 2023
    Copy the full SHA
    c9e6b81 View commit details
    Browse the repository at this point in the history