New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Formula-Cookbook: update for Homebrew v4 #14740
Conversation
Please provide a better issue/pull request title and/or description! |
Suggest setting
|
🤦🏻 thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR! Looking good so far, some wording tweaks, feel free to push back on any you disagree with and we can talk about them more.
This PR helped me work around a problem I had when creating a new formula. Looks like someone else had the same problem too. Linking this here in case it helps others. |
Co-authored-by: Mike McQuaid <mike@mikemcquaid.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @unitof, this looks great and is a huge improvement!
Co-authored-by: Eric Knibbe <enk3@outlook.com>
Directly related: #14757. Possibly even this PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks so much for your repeated contribution and sponsorship! Without people like you submitting PRs we couldn't run this project. You rock, @unitof!
brew style
with your changes locally?brew typecheck
with your changes locally?brew tests
with your changes locally?The Formula Cookbook includes some instructions which no longer work out of the box on Homebrew ≥4.0.0; this PR aims to update the documentation and correct the commands as necessary for local formulae development.
I don't believe any tests are necessary, but this is my first time contributing to docs so I could be wrong.
Fixes #14757