Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dev-cmd/contributions: Correctly order the trailers method args #14768

Merged
merged 1 commit into from Feb 22, 2023

Conversation

issyl0
Copy link
Member

@issyl0 issyl0 commented Feb 22, 2023

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally?

  • Was this a bad merge conflict resolution, or me not paying enough attention another time?

- Was this a bad merge conflict resolution, or me not paying enough
  attention another time?
@issyl0 issyl0 added the critical Critical change which should be shipped as soon as possible. label Feb 22, 2023
@BrewTestBot
Copy link
Member

Review period skipped due to critical label.

@issyl0 issyl0 merged commit 1b3fa0b into Homebrew:master Feb 22, 2023
@issyl0 issyl0 deleted the contributions-fix-trailers-args branch February 22, 2023 17:42
@github-actions github-actions bot added the outdated PR was locked due to age label Mar 25, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 25, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
critical Critical change which should be shipped as soon as possible. outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants