Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "cask: audit for correct signing of pkg installers" #14774

Merged

Conversation

bevanjkay
Copy link
Member

Reverts #14747

This change is currently causing cask CI audits to be broken.

The message variable is being defined before the result is available and causing audits to error out.
I'm about to start work, so don't have time to fix, but reverting this for now should get things going again.

 - exception while auditing wine-devel: undefined method `merged_output' for "\e[32mpassed\e[0m":String

@BrewTestBot
Copy link
Member

Review period will end on 2023-02-23 at 22:13:42 UTC.

@BrewTestBot BrewTestBot added the waiting for feedback Merging is blocked until sufficient time has passed for review label Feb 22, 2023
@bevanjkay bevanjkay added the critical Critical change which should be shipped as soon as possible. label Feb 22, 2023
@BrewTestBot BrewTestBot removed the waiting for feedback Merging is blocked until sufficient time has passed for review label Feb 22, 2023
@BrewTestBot
Copy link
Member

Review period skipped due to critical label.

@Bo98 Bo98 merged commit 2129b4c into Homebrew:master Feb 22, 2023
@github-actions github-actions bot added the outdated PR was locked due to age label Mar 25, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 25, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
critical Critical change which should be shipped as soon as possible. outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants