cask_loader: fix missing checksum in FromContentsLoader #14792
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bo98
added
the
critical
|
Review period skipped due to |
BrewTestBot
approved these changes
Feb 24, 2023
MikeMcQuaid
approved these changes
Feb 24, 2023
There was a problem hiding this comment.
Thanks again @Bo98! Again, non-blocking comment, merging without to fix the bug but possible follow-up.
Comment on lines
+48
to
+51
| checksum = { | ||
| "sha256" => Digest::SHA256.hexdigest(content), | ||
| } | ||
| Cask.new(header_token, source: content, source_checksum: checksum, **options, config: @config, &block) |
There was a problem hiding this comment.
Should this argument be made mandatory if things fail when it's not specified?
There was a problem hiding this comment.
It is not mandatory if sourcefile_path is passed.
I don't really like the million parameters that Cask's constructor can take so will see if there's anything better.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #14791