Scope HOMEBREW_NO_INSTALL_FROM_API to core formulae in brew audit
#14793
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bo98
added
the
critical
|
Review period skipped due to |
BrewTestBot
approved these changes
Feb 24, 2023
MikeMcQuaid
approved these changes
Feb 24, 2023
There was a problem hiding this comment.
Looks good, thanks for this @Bo98! Some nits but fine if this merges as-is if you disagree.
Library/Homebrew/utils.rb
Outdated
| @@ -317,6 +317,12 @@ def with_custom_locale(locale, &block) | |||
| with_env(LC_ALL: locale, &block) | |||
| end | |||
|
|
|||
| def without_api(&block) | |||
There was a problem hiding this comment.
Can this go into Library/Homebrew/dev-cmd/audit.rb as it's only used there?
There was a problem hiding this comment.
I would not be surprised if it is later used elsewhere e.g. brew test. But I guess I can shift it back to utils.rb later?
There was a problem hiding this comment.
@Bo98 Yup, or ideally something like Utils::API.without
Library/Homebrew/dev-cmd/audit.rb
Outdated
| odeprecated "brew audit [path ...]", | ||
| "brew audit [name ...]" | ||
| end | ||
| audit_formulae, audit_casks = without_api do |
There was a problem hiding this comment.
Comments explaining why this is needed would be nice here.
| @@ -209,8 +211,12 @@ def audit | |||
| display_cop_names: args.display_cop_names?, | |||
| }.compact | |||
|
|
|||
| fa = FormulaAuditor.new(f, **options) | |||
| fa.audit | |||
| audit_proc = proc { FormulaAuditor.new(f, **options).tap(&:audit) } | |||
There was a problem hiding this comment.
Comments explaining why this is needed would be nice here.
MikeMcQuaid
approved these changes
Feb 24, 2023
3 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #14701