New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move Kernel extensions into a separate file #14805
Conversation
Review period will end on 2023-02-27 at 18:54:36 UTC. |
Stupid question: what is |
27d3ea2
to
0507ef5
Compare
Oops, looks like that's something i have via an extension: https://github.com/tj/git-extras/blob/master/Commands.md#git-cp But I think I misunderstood the feature, it doesn't actually appear to carry over any history to the new file 😊 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, makes sense to me!
I do think, though, that many of these things could be pulled out of Kernel
and into somewhere more specific. Arguably almost all of this should either be in the Homebrew
module, imported into Formula
and/or a Utils
method or Utils::$NEWMODULE
.
0507ef5
to
1a0c02f
Compare
Review period ended. |
brew style
with your changes locally?brew typecheck
with your changes locally?brew tests
with your changes locally?Moves
Kernel
extensions toextend/kernel.rb
. This makes more logical sense to me, but was motivated by making space inutils.rb
for future top-levelUtils
method (as suggested in #14778 ). Both files remain untyped because they each rely on splats (which I'd prefer to leave out-of-scope for this PR).I used
git cp
so this should preserve history. I also movedutils_spec.rb
toextend/kernel_spec.rb
, because all of the tests in the file appear to beKernel
extension tests.