Set tap for casks when loading from contents via API #14814
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rylan12
added
the
critical
|
Review period skipped due to |
BrewTestBot
approved these changes
Feb 25, 2023
Bo98
approved these changes
Feb 25, 2023
I don't think this is needed in the same way. We already include set the tap when loading from the API, and don't do the same from-content loading |
|
I'm fine with this as a stopgap but I think in the long run it's just another example of why we should only load content from the source API during installation. Then we'd be able to skip all of this extra complexity. I'm working on a PR for that right now but not sure when it will be ready. Also, don't worry about #14713 because it's on ice right now until the cask loading stuff is handled. |
apainintheneck
approved these changes
Feb 26, 2023
MikeMcQuaid
reviewed
Feb 27, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that the tap is not set for casks when they are loading via their contents and the API. This means that things like
brew info --github --cask vlcdon't work as expected (I noticed this when looking at #14797).I'm not 100% sure this is the right way to handle this, though. Is there a better refactoring of the cask loader stuff that handles
tapmore universally? CC @Bo98 and @apainintheneck since I think you've touched this recently (and I'm not sure how this affects #14713)