Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

utils/github: Tiny improvements, boolean methods end in ? and remove unnecessary .delete_prefix("/") #14816

Merged
merged 2 commits into from Feb 27, 2023
Merged

utils/github: Tiny improvements, boolean methods end in ? and remove unnecessary .delete_prefix("/") #14816

merged 2 commits into from Feb 27, 2023

Conversation

issyl0
Copy link
Member

@issyl0 issyl0 commented Feb 26, 2023 •
edited

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally?
  • Tiny cleanup.
  • It's Ruby style convention that methods that return only booleans end with a question mark.
  • And I noticed that the GitHub code search API no longer returns a leading / on a file's path anymore, so we don't need the delete_prefix("/") workaround from 2020.

@BrewTestBot
Copy link
Member

Review period will end on 2023-02-28 at 00:00:00 UTC.

@BrewTestBot BrewTestBot added the waiting for feedback Merging is blocked until sufficient time has passed for review label Feb 26, 2023
@issyl0 issyl0 changed the title utils/github: Switch check_fork_exists to fork_exists? utils/github: Tiny improvements, boolean methods end in ? and remove unnecessary .delete_prefix("/") Feb 26, 2023
@issyl0
utils/github: Switch check_fork_exists to fork_exists?
550599d 
- It's Ruby style convention that methods that return only booleans end with a
  question mark.
@issyl0
utils/github: Remove unnecessary .delete_prefix("/")
214e210 
- This workaround was originally added in 2020. I have confirmed with
  https://api.github.com/search/code?q=brew+language%3Aruby+org:Homebrew that
  the `path` string no longer has a leading `/`.
@issyl0 issyl0 force-pushed the predicate-fork-exists-method branch from 24cabfc to 214e210 Compare February 26, 2023 15:27
MikeMcQuaid
MikeMcQuaid approved these changes Feb 27, 2023
View reviewed changes
Copy link
Member

@MikeMcQuaid MikeMcQuaid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice cleanup, thanks again @issyl0!

@MikeMcQuaid MikeMcQuaid added the critical Critical change which should be shipped as soon as possible. label Feb 27, 2023
@BrewTestBot BrewTestBot removed the waiting for feedback Merging is blocked until sufficient time has passed for review label Feb 27, 2023
@BrewTestBot
Copy link
Member

Review period skipped due to critical label.

@MikeMcQuaid MikeMcQuaid merged commit ee65414 into Homebrew:master Feb 27, 2023
@issyl0 issyl0 deleted the predicate-fork-exists-method branch February 28, 2023 00:22
@github-actions github-actions bot added the outdated PR was locked due to age label Mar 31, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 31, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@MikeMcQuaid MikeMcQuaid MikeMcQuaid approved these changes

@BrewTestBot BrewTestBot BrewTestBot approved these changes

@nandahkrishna nandahkrishna nandahkrishna approved these changes

Assignees
No one assigned
Labels
critical Critical change which should be shipped as soon as possible. outdated PR was locked due to age
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@issyl0 @BrewTestBot @MikeMcQuaid @nandahkrishna