Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dev-cmd/contributions: Stop counting signoffs now we have "real" reviews #14819

Merged
merged 1 commit into from Feb 28, 2023
Merged

dev-cmd/contributions: Stop counting signoffs now we have "real" reviews #14819

merged 1 commit into from Feb 28, 2023

Conversation

issyl0
Copy link
Member

@issyl0 issyl0 commented Feb 26, 2023

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally?
  • Signoffs were just a stopgap until we implemented getting "real" reviews for a user via the GitHub API. They were a suboptimal way of getting reviews because they only really exist in Homebrew/homebrew-core where BrewTestBot adds signoffs for each maintainer who reviewed the PR.

@BrewTestBot
Copy link
Member

Review period will end on 2023-02-28 at 00:00:00 UTC.

@BrewTestBot BrewTestBot added the waiting for feedback Merging is blocked until sufficient time has passed for review label Feb 26, 2023
nandahkrishna
nandahkrishna approved these changes Feb 26, 2023
View reviewed changes
Copy link
Member

@nandahkrishna nandahkrishna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense, thanks @issyl0!

MikeMcQuaid
MikeMcQuaid approved these changes Feb 27, 2023
View reviewed changes
Copy link
Member

@MikeMcQuaid MikeMcQuaid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me, nice work again @issyl0!

@BrewTestBot BrewTestBot removed the waiting for feedback Merging is blocked until sufficient time has passed for review label Feb 28, 2023
@BrewTestBot
Copy link
Member

Review period ended.

@issyl0
dev-cmd/contributions: Stop counting signoffs now we have "real" reviews
6b76e5e 
- Signoffs were just a stopgap until we implemented getting "real"
  reviews for a user via the GitHub API. They were a suboptimal way of getting
  reviews because they only really exist in Homebrew/homebrew-core where
  BrewTestBot adds signoffs for each maintainer who reviewed the PR.
@issyl0 issyl0 force-pushed the signoffs-were-just-a-stepping-stone-to-reviews branch from 142082e to 6b76e5e Compare February 28, 2023 11:13
@issyl0 issyl0 disabled auto-merge February 28, 2023 11:13
@issyl0 issyl0 merged commit 0f2270e into Homebrew:master Feb 28, 2023
@issyl0 issyl0 deleted the signoffs-were-just-a-stepping-stone-to-reviews branch February 28, 2023 11:37
@issyl0 issyl0 mentioned this pull request Mar 29, 2023
Merged
@github-actions github-actions bot added the outdated PR was locked due to age label Mar 31, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 31, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@MikeMcQuaid MikeMcQuaid MikeMcQuaid approved these changes

@BrewTestBot BrewTestBot BrewTestBot approved these changes

@nandahkrishna nandahkrishna nandahkrishna approved these changes

Assignees
No one assigned
Labels
outdated PR was locked due to age
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@issyl0 @BrewTestBot @MikeMcQuaid @nandahkrishna