Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

More Formula/Casks sharding fixes #14825

Merged
merged 1 commit into from Feb 28, 2023
Merged

More Formula/Casks sharding fixes #14825

merged 1 commit into from Feb 28, 2023

Conversation

MikeMcQuaid
Copy link
Member

@MikeMcQuaid MikeMcQuaid commented Feb 27, 2023 •
edited

@MikeMcQuaid MikeMcQuaid added the critical Critical change which should be shipped as soon as possible. label Feb 27, 2023
@BrewTestBot
Copy link
Member

Review period skipped due to critical label.

@Rylan12 Rylan12 mentioned this pull request Feb 27, 2023
Closed
@Rylan12
Copy link
Member

Rylan12 commented Feb 27, 2023 •
edited

Opened Homebrew/homebrew-cask#142047 to fix the style issue

Edit: maybe not, I'll look into it later

reitermarkus
reitermarkus reviewed Feb 28, 2023
View reviewed changes
Library/.rubocop.yml Outdated Show resolved Hide resolved
@MikeMcQuaid
More Formula/Casks sharding fixes
0406279 
- Stop `brew style` from complaining
- Fix message reference in `brew edit`
@Rylan12 Rylan12 merged commit f6af334 into Homebrew:master Feb 28, 2023
@MikeMcQuaid MikeMcQuaid deleted the more_sharding_fixes branch February 28, 2023 12:12
@github-actions github-actions bot added the outdated PR was locked due to age label Mar 31, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 31, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@reitermarkus reitermarkus reitermarkus left review comments

@carlocab carlocab carlocab left review comments

@BrewTestBot BrewTestBot BrewTestBot approved these changes

@Rylan12 Rylan12 Rylan12 approved these changes

Assignees
No one assigned
Labels
critical Critical change which should be shipped as soon as possible. outdated PR was locked due to age
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@MikeMcQuaid @BrewTestBot @Rylan12 @reitermarkus @carlocab