Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow version :latest if livecheck is skip. #14834

Merged
merged 1 commit into from Feb 28, 2023
Merged

Allow version :latest if livecheck is skip. #14834

merged 1 commit into from Feb 28, 2023

Conversation

reitermarkus
Copy link
Member

@reitermarkus reitermarkus commented Feb 28, 2023 •
edited

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally?

If there is a functional livecheck, a cask should not use version :latest. If the livecheck has skip, it should still be allowed as documentation why it cannot be versioned.

Fixes the remaining CI issue in Homebrew/homebrew-cask#141646.

@BrewTestBot
Copy link
Member

Review period will end on 2023-03-01 at 09:31:32 UTC.

@BrewTestBot BrewTestBot added the waiting for feedback Merging is blocked until sufficient time has passed for review label Feb 28, 2023
@MikeMcQuaid MikeMcQuaid added the critical Critical change which should be shipped as soon as possible. label Feb 28, 2023
@MikeMcQuaid
Copy link
Member

Thanks again @reitermarkus!

@BrewTestBot BrewTestBot removed the waiting for feedback Merging is blocked until sufficient time has passed for review label Feb 28, 2023
@BrewTestBot
Copy link
Member

Review period skipped due to critical label.

@MikeMcQuaid MikeMcQuaid merged commit 4cbc4f6 into Homebrew:master Feb 28, 2023
@reitermarkus reitermarkus deleted the livecheck-skip-latest branch February 28, 2023 14:46
samford
samford reviewed Feb 28, 2023
View reviewed changes
Copy link
Member

@samford samford left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewing this after merging but it makes sense to me 👍

@github-actions github-actions bot added the outdated PR was locked due to age label Mar 31, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 31, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@samford samford samford left review comments

@MikeMcQuaid MikeMcQuaid MikeMcQuaid approved these changes

@BrewTestBot BrewTestBot BrewTestBot approved these changes

@nandahkrishna nandahkrishna Awaiting requested review from nandahkrishna

Assignees
No one assigned
Labels
critical Critical change which should be shipped as soon as possible. outdated PR was locked due to age
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@reitermarkus @BrewTestBot @MikeMcQuaid @samford