Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move cask/cmd/info to cask/info #14839

Merged
merged 3 commits into from Mar 1, 2023
Merged

Move cask/cmd/info to cask/info #14839

merged 3 commits into from Mar 1, 2023
+112 −201

Conversation

hyuraku
Copy link
Contributor

@hyuraku hyuraku commented Feb 28, 2023

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally?

move functions of cask/cmd/info to cask/info because of #14799

MikeMcQuaid
MikeMcQuaid reviewed Feb 28, 2023
View reviewed changes
Copy link
Member

@MikeMcQuaid MikeMcQuaid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work so far @hyuraku, one method to remove and this should be good to go!

Library/Homebrew/cask/info.rb Outdated Show resolved Hide resolved
@MikeMcQuaid MikeMcQuaid merged commit 9296db0 into Homebrew:master Mar 1, 2023
@MikeMcQuaid
Copy link
Member

Thanks again @hyuraku!

@github-actions github-actions bot added the outdated PR was locked due to age label Apr 1, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 1, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@MikeMcQuaid MikeMcQuaid MikeMcQuaid approved these changes

Assignees
No one assigned
Labels
outdated PR was locked due to age
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@hyuraku @MikeMcQuaid