Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rubocop: Disable RSpec metrics cops #14869

Merged
merged 1 commit into from Mar 3, 2023
Merged

rubocop: Disable RSpec metrics cops #14869

merged 1 commit into from Mar 3, 2023

Conversation

issyl0
Copy link
Member

@issyl0 issyl0 commented Mar 2, 2023

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally?
  • We've disabled metrics cops for method length and complexity since we were fighting them a lot and the numbers were arbitrary and growing. It feels like these RSpec metrics numbers are arbitrary too.

@issyl0
rubocop: Disable RSpec metrics cops
46b946f 
- We've disabled metrics cops for method length and complexity since we were
  fighting them a lot and the numbers were arbitrary and growing. It feels like
  these RSpec metrics numbers are arbitrary too.
@BrewTestBot
Copy link
Member

Review period will end on 2023-03-03 at 21:59:55 UTC.

@BrewTestBot BrewTestBot added the waiting for feedback Merging is blocked until sufficient time has passed for review label Mar 2, 2023
@MikeMcQuaid MikeMcQuaid added the critical Critical change which should be shipped as soon as possible. label Mar 3, 2023
@MikeMcQuaid
Copy link
Member

Makes sense, thanks @issyl0!

@BrewTestBot BrewTestBot removed the waiting for feedback Merging is blocked until sufficient time has passed for review label Mar 3, 2023
@BrewTestBot
Copy link
Member

Review period skipped due to critical label.

@MikeMcQuaid MikeMcQuaid merged commit 1ad215d into Homebrew:master Mar 3, 2023
24 of 26 checks passed
@issyl0 issyl0 deleted the rubocop-rspec-metrics branch March 3, 2023 09:38
@github-actions github-actions bot added the outdated PR was locked due to age label Apr 3, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@MikeMcQuaid MikeMcQuaid MikeMcQuaid approved these changes

@BrewTestBot BrewTestBot BrewTestBot approved these changes

Assignees
No one assigned
Labels
critical Critical change which should be shipped as soon as possible. outdated PR was locked due to age
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@issyl0 @BrewTestBot @MikeMcQuaid