Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rubocop: Alphabetise, remove config that's default, in-line some disables #14871

Merged
merged 3 commits into from Mar 3, 2023
Merged

rubocop: Alphabetise, remove config that's default, in-line some disables #14871

merged 3 commits into from Mar 3, 2023

Conversation

issyl0
Copy link
Member

@issyl0 issyl0 commented Mar 2, 2023

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally?

@issyl0
rubocop: In-line Style/HashAsLastArrayItem disablement
e05cd2c 
- We want to move away from `Excludes:` in the main `.rubocop.yml` config file
  containing full file paths, because it's hard to track whether they're still
  necessary or not (and other occurrences in the files that you might
  legitimately want to improve are unaccounted for).
@issyl0
rubocop: Alphabetize list of cops, put Bundler/GemFilename first
81b0e41
@issyl0
rubocop: The default Style/FormatStringToken style is "annotated"
2091ef6
@MikeMcQuaid MikeMcQuaid added the critical Critical change which should be shipped as soon as possible. label Mar 3, 2023
@BrewTestBot
Copy link
Member

Review period skipped due to critical label.

@MikeMcQuaid
Copy link
Member

CI didn't run, maybe Actions downtime? Good to go once 🟢.

@issyl0
Copy link
Member Author

issyl0 commented Mar 3, 2023

Ah yeah, Actions was having issues last night.

@issyl0 issyl0 closed this Mar 3, 2023
auto-merge was automatically disabled March 3, 2023 11:38

Pull request was closed

@issyl0 issyl0 reopened this Mar 3, 2023
@issyl0 issyl0 merged commit 61cb843 into Homebrew:master Mar 3, 2023
25 checks passed
@issyl0 issyl0 deleted the rubocop-inline-disables branch March 3, 2023 12:10
@github-actions github-actions bot added the outdated PR was locked due to age label Apr 3, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@MikeMcQuaid MikeMcQuaid MikeMcQuaid approved these changes

@BrewTestBot BrewTestBot BrewTestBot approved these changes

Assignees
No one assigned
Labels
critical Critical change which should be shipped as soon as possible. outdated PR was locked due to age
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@issyl0 @BrewTestBot @MikeMcQuaid