Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rubocop: Enable Layout/MultilineMethodCallIndentation & fix offenses #14877

Merged
merged 1 commit into from Mar 6, 2023
Merged

rubocop: Enable Layout/MultilineMethodCallIndentation & fix offenses #14877

merged 1 commit into from Mar 6, 2023

Conversation

issyl0
Copy link
Member

@issyl0 issyl0 commented Mar 3, 2023

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally?
  • Part of Remove usage of Exclude with rubocop #14685.
  • The fixes here all seemed reasonable, with some minimal tweaks for line length and less floatiness. Apart from test/dev-cmd/bottle_spec.rb where RuboCop wanted to do some ridiculously floaty indentation and there wasn't an obvious alternative place to break the lines, so I opted for in-line disables instead.

@issyl0
rubocop: Enable Layout/MultilineMethodCallIndentation & fix offenses
734a651 
- Part of trying to reduce the number of `Excludes:` we have in our
  RuboCop configs.
- The fixes here all seemed reasonable, with some minimal tweaks for
  line length and less floatiness. Apart from `test/dev-cmd/bottle_spec.rb`
  where RuboCop wanted to do some ridiculously floaty indentation and there
  wasn't an obvious alternative place to break the lines, so I opted for
  in-line disables instead.
@BrewTestBot
Copy link
Member

Review period will end on 2023-03-06 at 22:20:46 UTC.

@BrewTestBot BrewTestBot added the waiting for feedback Merging is blocked until sufficient time has passed for review label Mar 3, 2023
@issyl0 issyl0 enabled auto-merge March 6, 2023 12:08
@MikeMcQuaid MikeMcQuaid added the critical Critical change which should be shipped as soon as possible. label Mar 6, 2023
@BrewTestBot BrewTestBot removed the waiting for feedback Merging is blocked until sufficient time has passed for review label Mar 6, 2023
@BrewTestBot
Copy link
Member

Review period skipped due to critical label.

@issyl0 issyl0 merged commit 984e8d1 into Homebrew:master Mar 6, 2023
24 of 26 checks passed
@issyl0 issyl0 deleted the rubocop-layout/multiline-method-indentation branch March 6, 2023 12:21
MikeMcQuaid
MikeMcQuaid approved these changes Mar 6, 2023
View reviewed changes
Copy link
Member

@MikeMcQuaid MikeMcQuaid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense, thanks again @issyl0!

@github-actions github-actions bot added the outdated PR was locked due to age label Apr 6, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 6, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@MikeMcQuaid MikeMcQuaid MikeMcQuaid approved these changes

@BrewTestBot BrewTestBot BrewTestBot approved these changes

Assignees
No one assigned
Labels
critical Critical change which should be shipped as soon as possible. outdated PR was locked due to age
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@issyl0 @BrewTestBot @MikeMcQuaid