Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

irb: add cask monkey patch #14885

Merged
merged 1 commit into from Mar 6, 2023
Merged

irb: add cask monkey patch #14885

merged 1 commit into from Mar 6, 2023

Conversation

apainintheneck
Copy link
Contributor

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally?

This makes it easier to load casks in repl sessions and matches what we already do with formulae.

@apainintheneck
brew/irb: add cask monkey patch
73f0fc3 
This makes it easier to load casks in repl sessions
and matches what we already do with formulae.
@BrewTestBot
Copy link
Member

Review period will end on 2023-03-07 at 00:00:00 UTC.

@BrewTestBot BrewTestBot added the waiting for feedback Merging is blocked until sufficient time has passed for review label Mar 4, 2023
@apainintheneck apainintheneck changed the title brew/irb: add cask monkey patch irb: add cask monkey patch Mar 4, 2023
Rylan12
Rylan12 approved these changes Mar 6, 2023
View reviewed changes
Copy link
Member

@Rylan12 Rylan12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉 this is a lifesaver

@MikeMcQuaid MikeMcQuaid added the critical Critical change which should be shipped as soon as possible. label Mar 6, 2023
@BrewTestBot BrewTestBot removed the waiting for feedback Merging is blocked until sufficient time has passed for review label Mar 6, 2023
@BrewTestBot
Copy link
Member

Review period skipped due to critical label.

MikeMcQuaid
MikeMcQuaid approved these changes Mar 6, 2023
View reviewed changes
Copy link
Member

@MikeMcQuaid MikeMcQuaid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! I wonder if we could use Refinements for this or something similar to make it a little more robust?

Merging as-is but CC @dduugg for thoughts here too.

@MikeMcQuaid MikeMcQuaid merged commit b08029e into Homebrew:master Mar 6, 2023
24 of 26 checks passed
@apainintheneck apainintheneck deleted the irb-add-cask-monkey-patch branch March 24, 2023 03:25
@github-actions github-actions bot added the outdated PR was locked due to age label Apr 24, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 24, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@MikeMcQuaid MikeMcQuaid MikeMcQuaid approved these changes

@BrewTestBot BrewTestBot BrewTestBot approved these changes

@Rylan12 Rylan12 Rylan12 approved these changes

@nandahkrishna nandahkrishna nandahkrishna approved these changes

Assignees
No one assigned
Labels
critical Critical change which should be shipped as soon as possible. outdated PR was locked due to age
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@apainintheneck @BrewTestBot @MikeMcQuaid @Rylan12 @nandahkrishna