Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rubocops/cask: Disallow protocol in cask URL verified stanza #14886

Merged
merged 5 commits into from Mar 6, 2023
Merged

rubocops/cask: Disallow protocol in cask URL verified stanza #14886

merged 5 commits into from Mar 6, 2023

Commits on Mar 4, 2023

  1. rubocops/cask: Disallow protocol in cask URL verified stanza 

    - Apparently the "verified" parameter in the URL (present when a Cask's
  download URL is not the same as its homepage) shouldn't have the
  protocol (`https`, `http`) at the front.
- Removing this has happened manually in the past, so here's an
  autocorrecting RuboCop for it.
    @issyl0
    issyl0 committed Mar 4, 2023
    Configuration menu
    Copy the full SHA
    79db987 View commit details
    Browse the repository at this point in the history

Commits on Mar 5, 2023

  1. rubocops/cask: Appease Sorbet with the correct inheritance 

    - The `on_url_stanza` method is now used in two cops, `Url` and
  `UrlLegacyCommaSeparators`. Make the latter inherit from the former
  to make Sorbet happy.
- The style and typecheck checks now pass fine.
    @issyl0
    issyl0 committed Mar 5, 2023
    Configuration menu
    Copy the full SHA
    f4a0bc7 View commit details
    Browse the repository at this point in the history

  2. rubocops/cask/url: Remove unnecessary require "forwardable"

    @issyl0
    issyl0 committed Mar 5, 2023
    Configuration menu
    Copy the full SHA
    4791224 View commit details
    Browse the repository at this point in the history

  3. rubocops/cask/url: Fix test expectations; regexp for starts_with?

    @issyl0
    issyl0 committed Mar 5, 2023
    Configuration menu
    Copy the full SHA
    4e06756 View commit details
    Browse the repository at this point in the history

  4. test/rubocops/cask/url: Ensure that autocorrection works

    @issyl0
    issyl0 committed Mar 5, 2023
    Configuration menu
    Copy the full SHA
    d995afc View commit details
    Browse the repository at this point in the history