Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

utils/github: Fix double counting of author/committer numbers #14889

Merged

Commits on Mar 5, 2023

  1. utils/github: Fix double counting of author/committer numbers

    - The usage of this in `brew contributions` wasn't correct for a user
      with 5 authored commits to homebrew/cask that had been committed by
      other people, the numbers would turn out as 5 authored, 5 committed.
    - I decided to do this properly by getting the SHAs for author and
      committer and determine the differences between the two arrays.
      This also accounts for when authored commits are 0, or committed
      commits, or both.
    - Add tests, because I don't want to fix this a third time!
    issyl0 committed Mar 5, 2023
    Configuration menu
    Copy the full SHA
    edeefeb View commit details
    Browse the repository at this point in the history