livecheck: Skip #preprocess_url for new strategies #14890
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
brew style
with your changes locally?brew typecheck
with your changes locally?brew tests
with your changes locally?I forgot to add the new
Json
,Xml
, andYaml
strategies to the list of strategies where#preprocess_url
should be skipped and this is causing issues for a user in their tap. This is unfortunately another bug that wasn't surfaced when I tested all the related checks in our first-party taps.In the not-too-distant future, I plan to rework how we use
#preprocess_url
. It only manipulates Git URLs at this point, so it arguably makes sense to move it into theGit
strategy as part of some refactoring of how certain strategy#match
methods work. Long story short, once that's done we won't have to worry about special-casing strategies with regard to#preprocess_url
.