Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

livecheck: Skip #preprocess_url for new strategies #14890

Conversation

samford
Copy link
Member

@samford samford commented Mar 5, 2023

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally?

I forgot to add the new Json, Xml, and Yaml strategies to the list of strategies where #preprocess_url should be skipped and this is causing issues for a user in their tap. This is unfortunately another bug that wasn't surfaced when I tested all the related checks in our first-party taps.

In the not-too-distant future, I plan to rework how we use #preprocess_url. It only manipulates Git URLs at this point, so it arguably makes sense to move it into the Git strategy as part of some refactoring of how certain strategy #match methods work. Long story short, once that's done we won't have to worry about special-casing strategies with regard to #preprocess_url.

I forgot to add the new `Json`, `Xml`, and `Yaml` strategies to the
list of strategies where `#preprocess_url` should be skipped and this
was causing issues for a user in their tap. This is unfortunately
another bug that wasn't surfaced when I tested all the related checks
in our first-party taps.
@samford samford added the critical Critical change which should be shipped as soon as possible. label Mar 5, 2023
@BrewTestBot
Copy link
Member

Review period skipped due to critical label.

@samford samford merged commit 74e1e4c into Homebrew:master Mar 5, 2023
@samford samford deleted the livecheck/skip-preprocess_url-for-new-strategies branch March 5, 2023 16:09
@github-actions github-actions bot added the outdated PR was locked due to age label Apr 5, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 5, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
critical Critical change which should be shipped as soon as possible. outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants