Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: Move from Ubuntu 18.04 to Ubuntu 20.04 Actions runners #14910

Merged
merged 1 commit into from Mar 7, 2023
Merged

ci: Move from Ubuntu 18.04 to Ubuntu 20.04 Actions runners #14910

merged 1 commit into from Mar 7, 2023

Conversation

issyl0
Copy link
Member

@issyl0 issyl0 commented Mar 6, 2023 •
edited

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally?

@BrewTestBot
Copy link
Member

Review period will end on 2023-03-07 at 21:51:09 UTC.

@BrewTestBot BrewTestBot added the waiting for feedback Merging is blocked until sufficient time has passed for review label Mar 6, 2023
@Rylan12 Rylan12 added the critical Critical change which should be shipped as soon as possible. label Mar 7, 2023
@BrewTestBot BrewTestBot removed the waiting for feedback Merging is blocked until sufficient time has passed for review label Mar 7, 2023
@BrewTestBot
Copy link
Member

Review period skipped due to critical label.

@iMichka
Copy link
Member

iMichka commented Mar 7, 2023

Should we test on ubuntu 20.04? I think these tests were there to check if everything works fine on an older stack (glibc and so on), if I am not mistaken?

MikeMcQuaid
MikeMcQuaid requested changes Mar 7, 2023
View reviewed changes
Copy link
Member

@MikeMcQuaid MikeMcQuaid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please switch these to 20.04 rather than removing them. We need to ensure we're testing a non-22.04 configuration so that we can ensure the brewed gcc/glibc path works. Thanks for the PR ❤️

@issyl0
ci: Move to Ubuntu 20.04 Actions runners
b95c549 
- The 18.04 runners are deprecated and going away in less than a month.
  Today was another scheduled brownout from GitHub
  (https://github.blog/changelog/2022-08-09-github-actions-the-ubuntu-18-04-actions-runner-image-is-being-deprecated-and-will-be-removed-by-12-1-22/),
  and they've been unmarked as required checks in the branch protections
  because the images are unavailable and the jobs were failing.
- However, we still need to test that Homebrew works correctly on
  non-latest Ubuntu versions so that we can test that we're correctly
  using brewed gcc/glibc, hence upgrading to 20.04 which is still old.
@issyl0 issyl0 requested a review from MikeMcQuaid March 7, 2023 12:50
@issyl0 issyl0 force-pushed the ubuntu-1804-actions-runners-brownout branch from b08f6af to b95c549 Compare March 7, 2023 12:50
@issyl0 issyl0 changed the title ci: Stop running tests on Ubuntu 18.04 Actions runners ci: Move from Ubuntu 18.04 to Ubuntu 20.04 Actions runners Mar 7, 2023
MikeMcQuaid
MikeMcQuaid approved these changes Mar 7, 2023
View reviewed changes
Copy link
Member

@MikeMcQuaid MikeMcQuaid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @issyl0! Can you toggle these back to required after this is merged?

@MikeMcQuaid MikeMcQuaid merged commit 246b36c into Homebrew:master Mar 7, 2023
@issyl0 issyl0 deleted the ubuntu-1804-actions-runners-brownout branch March 7, 2023 14:50
@issyl0
Copy link
Member Author

issyl0 commented Mar 7, 2023

Done!

@github-actions github-actions bot added the outdated PR was locked due to age label Apr 7, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 7, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@MikeMcQuaid MikeMcQuaid MikeMcQuaid approved these changes

@BrewTestBot BrewTestBot BrewTestBot approved these changes

@dawidd6 dawidd6 dawidd6 approved these changes

@Rylan12 Rylan12 Rylan12 approved these changes

@nandahkrishna nandahkrishna nandahkrishna approved these changes

Assignees
No one assigned
Labels
critical Critical change which should be shipped as soon as possible. outdated PR was locked due to age
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@issyl0 @BrewTestBot @iMichka @MikeMcQuaid @dawidd6 @Rylan12 @nandahkrishna