Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump-formula-pr: add release notes if found #14918

Merged
merged 5 commits into from Mar 8, 2023

Conversation

SMillerDev
Copy link
Member

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally?

This should allow maintainers to quickly spot important information about a release (if it's on GitHub)

@BrewTestBot
Copy link
Member

Review period will end on 2023-03-08 at 18:42:51 UTC.

@BrewTestBot BrewTestBot added the waiting for feedback Merging is blocked until sufficient time has passed for review label Mar 7, 2023
@BrewTestBot BrewTestBot added waiting for feedback Merging is blocked until sufficient time has passed for review and removed waiting for feedback Merging is blocked until sufficient time has passed for review labels Mar 8, 2023
@SMillerDev SMillerDev marked this pull request as ready for review March 8, 2023 07:02
@BrewTestBot BrewTestBot added waiting for feedback Merging is blocked until sufficient time has passed for review and removed waiting for feedback Merging is blocked until sufficient time has passed for review labels Mar 8, 2023
Library/Homebrew/dev-cmd/bump-formula-pr.rb Outdated Show resolved Hide resolved
Library/Homebrew/dev-cmd/bump-formula-pr.rb Outdated Show resolved Hide resolved
Library/Homebrew/dev-cmd/bump-formula-pr.rb Outdated Show resolved Hide resolved
SMillerDev and others added 3 commits March 8, 2023 13:58
Co-authored-by: Mike McQuaid <mike@mikemcquaid.com>
Co-authored-by: Mike McQuaid <mike@mikemcquaid.com>
Co-authored-by: Mike McQuaid <mike@mikemcquaid.com>
@MikeMcQuaid MikeMcQuaid added the critical Critical change which should be shipped as soon as possible. label Mar 8, 2023
@BrewTestBot BrewTestBot removed the waiting for feedback Merging is blocked until sufficient time has passed for review label Mar 8, 2023
@BrewTestBot
Copy link
Member

Review period skipped due to critical label.

@MikeMcQuaid MikeMcQuaid merged commit 8d71aa0 into Homebrew:master Mar 8, 2023
24 of 25 checks passed
@RandomDSdevel
Copy link
Contributor

RandomDSdevel commented Mar 9, 2023

     I could be wrong, but I just thought I'd note thatthis change feels like it's doing a bit of work in roughly the same space as the old #2935 and #5744, albeit not as a user-facing 'brew' command, internal or external, and only covering formulas and casks from GitHub with release notes extractable from GitHub Releases pages.

@SMillerDev
Copy link
Member Author

Yeah, I had a similar idea to those but toned it down to this to start with.

@chenrui333
Copy link
Member

Like the idea, but we might need to find a way of replacing all the github issue links in the release notes, currently, it messed up the PR/issue references in homebrew-core repo.

@MikeMcQuaid
Copy link
Member

Like the idea, but we might need to find a way of replacing all the github issue links in the release notes, currently, it messed up the PR/issue references in homebrew-core repo.

@chenrui333 Can you provide some examples? Thanks!

@SMillerDev
Copy link
Member Author

Someone can wrap it in <pre></pre> but I don't have time for that now.

@github-actions github-actions bot added the outdated PR was locked due to age label Apr 12, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
critical Critical change which should be shipped as soon as possible. outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants