Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

github_packages: additional retry of skopeo copy with backoff #14932

Merged
merged 2 commits into from Mar 9, 2023
Merged

github_packages: additional retry of skopeo copy with backoff #14932

merged 2 commits into from Mar 9, 2023

Conversation

dawidd6
Copy link
Member

@dawidd6 dawidd6 commented Mar 9, 2023

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally?

I hope this isn't going too far. Another failures (that aren't handled by skopeo, see Homebrew/homebrew-core#125152 (comment)) have been seen recently:
https://github.com/Homebrew/homebrew-core/actions/runs/4370167585/jobs/7644794677
https://github.com/Homebrew/homebrew-core/actions/runs/4370971036/jobs/7646393927

@BrewTestBot
Copy link
Member

Review period will end on 2023-03-10 at 08:19:13 UTC.

@BrewTestBot BrewTestBot added the waiting for feedback Merging is blocked until sufficient time has passed for review label Mar 9, 2023
MikeMcQuaid
MikeMcQuaid approved these changes Mar 9, 2023
View reviewed changes
Copy link
Member

@MikeMcQuaid MikeMcQuaid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeh, I think combined 25 retries is too many. Let's have --retry-times= 1-3 and then can leave this as is here. Good call on the exponential back-off.

Approving just because I don't care enough to actually block this and want this to be more resilient.

@MikeMcQuaid MikeMcQuaid added the critical Critical change which should be shipped as soon as possible. label Mar 9, 2023
@BrewTestBot BrewTestBot removed the waiting for feedback Merging is blocked until sufficient time has passed for review label Mar 9, 2023
@BrewTestBot
Copy link
Member

Review period skipped due to critical label.

@dawidd6 dawidd6 marked this pull request as ready for review March 9, 2023 08:43
@dawidd6 dawidd6 enabled auto-merge March 9, 2023 08:43
@dawidd6 dawidd6 merged commit 8824fc2 into master Mar 9, 2023
22 of 23 checks passed
@dawidd6 dawidd6 deleted the skopeo-retry-backoff branch March 9, 2023 09:47
@dawidd6
Copy link
Member Author

dawidd6 commented Mar 9, 2023

In action: https://github.com/Homebrew/homebrew-core/actions/runs/4372756960/jobs/7650907898

@github-actions github-actions bot added the outdated PR was locked due to age label Apr 9, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 9, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@MikeMcQuaid MikeMcQuaid MikeMcQuaid approved these changes

@BrewTestBot BrewTestBot BrewTestBot approved these changes

Assignees
No one assigned
Labels
critical Critical change which should be shipped as soon as possible. outdated PR was locked due to age
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@dawidd6 @BrewTestBot @MikeMcQuaid