Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup irb history file in tests #14940

Merged
merged 1 commit into from Mar 10, 2023

Conversation

apainintheneck
Copy link
Contributor

@apainintheneck apainintheneck commented Mar 10, 2023

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally?

This was caused by the irb spec which I forgot to update while working on this command a few days ago. Note that $HOME is set during the test setup so will always be correct.

Before

/u/l/Homebrew (master|✔) $ git status
On branch master
Your branch is up to date with 'origin/master'.

nothing to commit, working tree clean
/u/l/Homebrew (master|✔) $ brew tests --only=dev-cmd/irb
Randomized with seed 26142
1 process for 1 spec, ~ 1 spec per process
..
Took 5 seconds
/u/l/Homebrew (master|✔) $ git status
On branch master
Your branch is up to date with 'origin/master'.

Untracked files:
  (use "git add <file>..." to include in what will be committed)
        Library/Homebrew/test/.brew_irb_history

nothing added to commit but untracked files present (use "git add" to track)

After

/u/l/Homebrew (master|✔) $ git checkout fix-irb-test
Switched to branch 'fix-irb-test'
/u/l/Homebrew (fix-irb-test|✔) $ brew tests --only=dev-cmd/irb
Randomized with seed 26186
1 process for 1 spec, ~ 1 spec per process
..
Took 5 seconds
/u/l/Homebrew (fix-irb-test|✔) $ git status
On branch fix-irb-test
nothing to commit, working tree clean

This was caused by the irb spec. Note that
$HOME is set during the test setup so will
always be correct.
@apainintheneck apainintheneck added the bug Reproducible Homebrew/brew bug label Mar 10, 2023
@BrewTestBot
Copy link
Member

Review period will end on 2023-03-13 at 01:16:57 UTC.

@BrewTestBot BrewTestBot added the waiting for feedback Merging is blocked until sufficient time has passed for review label Mar 10, 2023
@apainintheneck apainintheneck mentioned this pull request Mar 10, 2023
7 tasks
@MikeMcQuaid MikeMcQuaid added the critical Critical change which should be shipped as soon as possible. label Mar 10, 2023
@BrewTestBot BrewTestBot removed the waiting for feedback Merging is blocked until sufficient time has passed for review label Mar 10, 2023
@BrewTestBot
Copy link
Member

Review period skipped due to critical label.

Copy link
Member

@MikeMcQuaid MikeMcQuaid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks again @apainintheneck!

@MikeMcQuaid MikeMcQuaid merged commit fad4414 into Homebrew:master Mar 10, 2023
24 of 27 checks passed
@apainintheneck apainintheneck deleted the fix-irb-test branch March 24, 2023 03:25
@github-actions github-actions bot added the outdated PR was locked due to age label Apr 24, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 24, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Reproducible Homebrew/brew bug critical Critical change which should be shipped as soon as possible. outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants