Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create .git/info dir if it doesn't exist #14957

Merged
merged 1 commit into from Mar 13, 2023

Conversation

hmarr
Copy link
Contributor

@hmarr hmarr commented Mar 13, 2023

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally?

Most of the time, a fresh repository init / clone includes a .git/info directory. However, if a custom git template directory is used, and that template doesn't include an info directory, the .git/info directory will be missing from the new repository checkout. That causes the sparse checkout download strategy to fail when it tries to write to .git/info/sparse-checkout (Homebrew/homebrew-cask-fonts#6961). This change ensures the directory exists before writing that file.

I was able to reproduce the crash in Homebrew/homebrew-cask-fonts#6961 by installing the font, deleting the .git/info directory, then reinstalling the font. After applying this change, I was unable to reproduce the crash.

Fixes Homebrew/homebrew-cask-fonts#6961.

Copy link
Member

@MikeMcQuaid MikeMcQuaid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense, thanks again @hmarr!

@MikeMcQuaid MikeMcQuaid merged commit 488728e into Homebrew:master Mar 13, 2023
@hmarr hmarr deleted the create-git-info-dir branch March 13, 2023 23:14
@github-actions github-actions bot added the outdated PR was locked due to age label Apr 13, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 13, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

font-bona-nova installation fails
2 participants