Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Retry if DMG BOM is empty. #14958

Merged
merged 1 commit into from Mar 13, 2023
Merged

Conversation

reitermarkus
Copy link
Member

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally?

This error is pretty much impossible to reproduce and only happens rarely on CI.

My naive guess is that mounting a DMG on CI is slow sometimes meaning we try finding files which aren't mounted yet. Not sure if that's actually how hdiutil works but we'll see.

Fail in both cases, so we actually see if retrying fixes this or not.

@BrewTestBot
Copy link
Member

Review period will end on 2023-03-14 at 17:34:18 UTC.

@BrewTestBot BrewTestBot added the waiting for feedback Merging is blocked until sufficient time has passed for review label Mar 13, 2023
@reitermarkus reitermarkus requested a review from a team March 13, 2023 17:35
Copy link
Member

@p-linnane p-linnane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Every time I've seen this happen it's fixed by a rerun, so this would be useful.

@MikeMcQuaid MikeMcQuaid added the critical Critical change which should be shipped as soon as possible. label Mar 13, 2023
@MikeMcQuaid
Copy link
Member

Makes sense, thanks @reitermarkus!

@BrewTestBot BrewTestBot removed the waiting for feedback Merging is blocked until sufficient time has passed for review label Mar 13, 2023
@BrewTestBot
Copy link
Member

Review period skipped due to critical label.

@MikeMcQuaid MikeMcQuaid merged commit 78eeccf into Homebrew:master Mar 13, 2023
24 of 26 checks passed
@reitermarkus reitermarkus deleted the empty-bom-retry branch March 20, 2023 23:44
@github-actions github-actions bot added the outdated PR was locked due to age label Apr 20, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 20, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
critical Critical change which should be shipped as soon as possible. outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants