Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix env_config generator. #14979

Merged
merged 1 commit into from Mar 15, 2023
Merged

Fix env_config generator. #14979

merged 1 commit into from Mar 15, 2023

Conversation

reitermarkus
Copy link
Member

@reitermarkus reitermarkus commented Mar 15, 2023 •
edited

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally?

Fixes error in #14977.

@BrewTestBot
Copy link
Member

Review period will end on 2023-03-16 at 13:29:39 UTC.

@BrewTestBot BrewTestBot added the waiting for feedback Merging is blocked until sufficient time has passed for review label Mar 15, 2023
@reitermarkus reitermarkus added the critical Critical change which should be shipped as soon as possible. label Mar 15, 2023
@BrewTestBot BrewTestBot removed the waiting for feedback Merging is blocked until sufficient time has passed for review label Mar 15, 2023
@BrewTestBot
Copy link
Member

Review period skipped due to critical label.

@reitermarkus reitermarkus merged commit ed83104 into Homebrew:master Mar 15, 2023
23 of 26 checks passed
@reitermarkus reitermarkus deleted the env-config-generator branch March 15, 2023 13:44
@github-actions github-actions bot added the outdated PR was locked due to age label Apr 15, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 15, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@BrewTestBot BrewTestBot BrewTestBot approved these changes

@issyl0 issyl0 Awaiting requested review from issyl0

Assignees
No one assigned
Labels
critical Critical change which should be shipped as soon as possible. outdated PR was locked due to age
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@reitermarkus @BrewTestBot