cask/audit: Pass a URL's referer through to cURL
#14991
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review period will end on 2023-03-17 at 00:36:54 UTC. |
BrewTestBot
added
the
waiting for feedback
- Some casks have URL arguments like "referer" (spelled wrong, that's intentional in the HTTP spec). - The audit for one such cask, `iThoughtsX`, was failing because the "referer" wasn't getting passed through to cURL so the access would 404. ---- Before: ``` ❯ brew audit --cask --online --appcast --signing 'ithoughtsx' [...] audit for ithoughtsx: failed - The binary URL https://cdn.toketaware.com?download=iThoughtsX.zip is not reachable (HTTP status code 404) - Version '9.2.0' differs from '9.3.0' retrieved by livecheck. - Version '9.2.0' differs from '9.3.0' retrieved by livecheck. Error: 2 problems in 1 cask detected ``` After: ``` ❯ brew audit --cask --online --appcast --signing 'ithoughtsx' [...] audit for ithoughtsx: failed - Version '9.2.0' differs from '9.3.0' retrieved by livecheck. - Version '9.2.0' differs from '9.3.0' retrieved by livecheck. Error: 1 problem in 1 cask detected ```
issyl0
force-pushed
the
cask-url-audit-pass-referrer
branch
from
6d015ba
to
0701ea4
Compare
BrewTestBot
removed
the
waiting for feedback
|
Review period ended. |
BrewTestBot
approved these changes
Mar 17, 2023
MikeMcQuaid
approved these changes
Mar 17, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
brew stylewith your changes locally?brew typecheckwith your changes locally?brew testswith your changes locally?curl_http_content_headers_and_checksumaudit not passing arguments (referer) #14607.iThoughtsX, was failing because the "referer" wasn't getting passed through to cURL so the access would 404.TODO:
Before:
After: