Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

utils/github/actions: remove Error class #15005

Merged
merged 1 commit into from Mar 18, 2023

Conversation

nandahkrishna
Copy link
Member

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally?

As pointed out in #15002 (comment), we don't really need the Error class as we're not rescuing from it anywhere. Let's avoid having unnecessary code 馃槄.

@nandahkrishna nandahkrishna added the critical Critical change which should be shipped as soon as possible. label Mar 18, 2023
@BrewTestBot
Copy link
Member

Review period skipped due to critical label.

@nandahkrishna nandahkrishna merged commit e89492f into Homebrew:master Mar 18, 2023
23 checks passed
@nandahkrishna nandahkrishna deleted the actions-error-remove branch March 18, 2023 20:59
@github-actions github-actions bot added the outdated PR was locked due to age label Apr 18, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 18, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
critical Critical change which should be shipped as soon as possible. outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants