Enable UnpackStrategy types #15025
Merged
Enable UnpackStrategy types #15025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review period will end on 2023-03-21 at 22:14:20 UTC. |
BrewTestBot
added
the
waiting for feedback
dduugg
force-pushed
the
enable-unpack-strategy-types
branch
from
421c86b
to
877af48
Compare
dduugg
commented
Mar 21, 2023
Library/Homebrew/extend/pathname.rb
Outdated
| else | ||
| # Length of the longest regex (currently Tar). | ||
| # The `T.let` is a workaround until we have https://github.com/sorbet/sorbet/pull/6865 | ||
| T.let(binread(262), T.nilable(String)) || "" |
There was a problem hiding this comment.
262 was formerly MAX_MAGIC_NUMBER_LENGTH, but i didn't want to add more than necessary to the Pathname space, or add any redirection.
There was a problem hiding this comment.
@dduugg please make it a named variable at least instead for readability, thanks!
Suggested change
| T.let(binread(262), T.nilable(String)) || "" | |
| max_magic_number_length = 262 | |
| T.let(binread(max_magic_number_length), T.nilable(String)) || "" |
Library/Homebrew/extend/pathname.rb
Outdated
| "" | ||
| else | ||
| # Length of the longest regex (currently Tar). | ||
| # The `T.let` is a workaround until we have https://github.com/sorbet/sorbet/pull/6865 |
There was a problem hiding this comment.
Suggested change
| # The `T.let` is a workaround until we have https://github.com/sorbet/sorbet/pull/6865 | |
| # FIXME: The `T.let` is a workaround until we have https://github.com/sorbet/sorbet/pull/6865 |
BrewTestBot
removed
the
waiting for feedback
|
Review period ended. |
BrewTestBot
approved these changes
Mar 22, 2023
dduugg
force-pushed
the
enable-unpack-strategy-types
branch
from
b37c313
to
91afda6
Compare
|
Updated PR to address comments and fix merge conflicts. PTAL @reitermarkus @MikeMcQuaid |
MikeMcQuaid
approved these changes
Mar 22, 2023
There was a problem hiding this comment.
Looks good! If my one suggestion is correct: please apply it and merge/enable auto-merge without another round of review being needed. Feel free to wait for @reitermarkus if desired.
Co-authored-by: Mike McQuaid <mike@mikemcquaid.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
brew stylewith your changes locally?brew typecheckwith your changes locally?brew testswith your changes locally?Pathnamerefinements in two modules,PathnameEachDirectoryandBom, that were confined to the file they were defined in, and which better written as utility functions.Pathnamerefinements in another module,Magic, to monkey-patchPathnameinstead. (This was already being included in 34 files, so it was already basically a monkey-patch). Monkey-patching isn't great, but it's still generally better than using refinements for reasons discussed in Use ActiveSupport Hash#assert_valid_keys instead of refinement #15018