New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
move cask/cmd/reinstall
#15040
move cask/cmd/reinstall
#15040
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good so far, one small nit!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One more nit: just want to make sure we don't override an explicit quarantine: false
.
Library/Homebrew/cask/reinstall.rb
Outdated
|
||
casks.each do |cask| | ||
Installer.new(cask, | ||
binaries: binaries, | ||
verbose: verbose, | ||
force: force, | ||
skip_cask_deps: skip_cask_deps, | ||
require_sha: require_sha, | ||
quarantine: quarantine || true, | ||
zap: zap).reinstall |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
casks.each do |cask| | |
Installer.new(cask, | |
binaries: binaries, | |
verbose: verbose, | |
force: force, | |
skip_cask_deps: skip_cask_deps, | |
require_sha: require_sha, | |
quarantine: quarantine || true, | |
zap: zap).reinstall | |
quarantine = true if quarantine.nil? | |
casks.each do |cask| | |
Installer.new(cask, | |
binaries: binaries, | |
verbose: verbose, | |
force: force, | |
skip_cask_deps: skip_cask_deps, | |
require_sha: require_sha, | |
quarantine: quarantine, | |
zap: zap).reinstall |
Thanks again @hyuraku! |
brew style
with your changes locally?brew typecheck
with your changes locally?brew tests
with your changes locally?move
cask/cmd/reinstall
tocask/reinstall
because of #14799