Enable typing in Ignorable #15114
Merged
Enable typing in Ignorable #15114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dduugg
commented
Mar 31, 2023
| @@ -99,7 +99,7 @@ def self.debrew | |||
| end | |||
|
|
|||
| def self.debug(exception) | |||
| raise(exception) if !active? || !debugged_exceptions.add?(exception) || !try_lock | |||
| raise(exception) if !active? || !debugged_exceptions.add?(exception) || !mu_try_lock | |||
There was a problem hiding this comment.
This switches to using the mu_ methods bc sorbet doesn't recognize the aliased versions, but I believe they are equivalent:
[1] brew(main)> require 'debrew'
=> true
[2] brew(main)> $ Debrew.try_lock
From: /System/Library/Frameworks/Ruby.framework/Versions/2.6/usr/lib/ruby/2.6.0/mutex_m.rb:86:
Owner: #<Class:Debrew>
Visibility: public
Signature: try_lock()
Number of lines: 3
def mu_try_lock
@_mutex.try_lock
end
| @@ -54,7 +54,7 @@ def self.update_test | |||
| start_commit = T.let("", T.untyped) | |||
| end_commit = "HEAD" | |||
| cd HOMEBREW_REPOSITORY do | |||
| start_commit = if (commit = T.let(args.commit, T.nilable(String))) | |||
| start_commit = if (commit = args.commit) | |||
There was a problem hiding this comment.
Follow-up to #15104 (comment)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
brew stylewith your changes locally?brew typecheckwith your changes locally?brew testswith your changes locally?Enables typing for the
IgnorableandDebrewfiles.Restores the upstream.rbi file to include type definitions that are necessary but not in our version of sorbet. (They're a pair of private methods, so pretending them with
T.unsafe(self)doesn't work.)