Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make test not depend on macOS version. #15206

Merged
merged 2 commits into from Apr 12, 2023

Conversation

reitermarkus
Copy link
Member

@reitermarkus reitermarkus commented Apr 11, 2023

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally?

Copy link
Member

@issyl0 issyl0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Markus, this is better than fixing it every time someone tweaks these tests while not running Ventura (or the other way around).

Co-authored-by: Issy Long <issyl0@github.com>
@apainintheneck apainintheneck merged commit 9f1d00e into Homebrew:master Apr 12, 2023
24 checks passed
@MikeMcQuaid
Copy link
Member

Thanks @reitermarkus!

@reitermarkus reitermarkus deleted the macos-version-tests branch April 12, 2023 12:37
@github-actions github-actions bot added the outdated PR was locked due to age label May 13, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 13, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants