Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add --os=all and --arch=all options for brew audit. #15225

Merged
merged 2 commits into from May 19, 2023

Conversation

reitermarkus
Copy link
Member

@reitermarkus reitermarkus commented Apr 14, 2023

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally?

Needs to be rebased onto #15201.

@reitermarkus reitermarkus force-pushed the audit-os-arch branch 4 times, most recently from 08fd0d4 to 814115b Compare April 21, 2023 00:43
@reitermarkus reitermarkus force-pushed the audit-os-arch branch 24 times, most recently from d0d4251 to 3257f50 Compare May 5, 2023 03:22
@reitermarkus reitermarkus force-pushed the audit-os-arch branch 2 times, most recently from 21d858c to 2f8f30d Compare May 5, 2023 05:34
Copy link
Member

@MikeMcQuaid MikeMcQuaid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is looking good so far! I have to be honest and say that I haven't given every line detailed review. Is there any way to split this into multiple, smaller PRs for review before merge?

Similarly, I have mild concerns with the amount of code that's not covered by any tests but want to avoid adding new integration tests for all these commands. Suggestions welcome, may not be blocking.

Thanks again @reitermarkus, great work here.

Library/Homebrew/cli/args.rb Outdated Show resolved Hide resolved
Library/Homebrew/formulary.rb Show resolved Hide resolved
Copy link
Member

@MikeMcQuaid MikeMcQuaid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good! A few questions and thoughts here but nothing major. Nice work @reitermarkus!

Library/Homebrew/cli/args.rb Outdated Show resolved Hide resolved
Library/Homebrew/cli/args.rb Show resolved Hide resolved
Library/Homebrew/cli/named_args.rb Show resolved Hide resolved
Library/Homebrew/cmd/fetch.rb Show resolved Hide resolved
Library/Homebrew/extend/os/mac/diagnostic.rb Show resolved Hide resolved
Library/Homebrew/formula_versions.rb Show resolved Hide resolved
Copy link
Member

@MikeMcQuaid MikeMcQuaid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One style nit if you can be bothered but fine if this ships as-is. Thanks again @reitermarkus!

Library/Homebrew/cli/named_args.rb Show resolved Hide resolved
Library/Homebrew/cmd/fetch.rb Show resolved Hide resolved
Library/Homebrew/extend/os/mac/diagnostic.rb Show resolved Hide resolved
Library/Homebrew/formula_versions.rb Show resolved Hide resolved
@reitermarkus reitermarkus merged commit e9bfcb9 into Homebrew:master May 19, 2023
29 checks passed
@reitermarkus reitermarkus deleted the audit-os-arch branch May 19, 2023 13:03
@github-actions github-actions bot added the outdated PR was locked due to age label Jun 19, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants