New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add --os=all
and --arch=all
options for brew audit
.
#15225
Conversation
08fd0d4
to
814115b
Compare
d0d4251
to
3257f50
Compare
21d858c
to
2f8f30d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is looking good so far! I have to be honest and say that I haven't given every line detailed review. Is there any way to split this into multiple, smaller PRs for review before merge?
Similarly, I have mild concerns with the amount of code that's not covered by any tests but want to avoid adding new integration tests for all these commands. Suggestions welcome, may not be blocking.
Thanks again @reitermarkus, great work here.
628f972
to
83f3ea7
Compare
f2a8311
to
b812864
Compare
b812864
to
5e4ab41
Compare
5e4ab41
to
0782df8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good! A few questions and thoughts here but nothing major. Nice work @reitermarkus!
0782df8
to
a97e63e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One style nit if you can be bothered but fine if this ships as-is. Thanks again @reitermarkus!
brew style
with your changes locally?brew typecheck
with your changes locally?brew tests
with your changes locally?Needs to be rebased onto #15201.