Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

github_packages: fix bottle manifest schema violation #15248

Merged
merged 1 commit into from Apr 17, 2023

Conversation

ZhongRuoyu
Copy link
Member

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally?

According to 1 2, image manifest annotations need to be a string-string map.

This should fix the errors seen in Homebrew/homebrew-core#128517, Homebrew/homebrew-core#128558, et al.

Footnotes

  1. https://github.com/opencontainers/image-spec/blob/2879913ce4bc229704bf0d67b280929007b06b94/schema/image-manifest-schema.json#L35

  2. https://github.com/opencontainers/image-spec/blob/2879913ce4bc229704bf0d67b280929007b06b94/schema/defs-descriptor.json#L22

@carlocab carlocab merged commit e98bfdd into Homebrew:master Apr 17, 2023
22 checks passed
@ZhongRuoyu ZhongRuoyu deleted the bottle-manifest branch April 17, 2023 15:42
@github-actions github-actions bot added the outdated PR was locked due to age label May 18, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 18, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants