New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable Sorbet/TrueSigil cop #15274
Enable Sorbet/TrueSigil cop #15274
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
On the "ignore tests" part, I don't know anything about the desired state of typechecking test files - is this a thing that is never going to be done, or might be when the landscape is better, or should be done now or incrementally when people get time? I wonder what would happen if we set typed: true
for tests. 🤔
I've managed to do it in a gem by introducing an rspec context that i typecheck independently of the rest of the code. I think the main issue here would bethat any test using |
Ah, we use a lot of |
IMO: it's not worth type checking these files at all and I'd favour even removing the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks again @dduugg!
That's a reasonable stylistic choice, since |
Another thing worth considering (I can make an issue again if helpful): enabling |
brew style
with your changes locally?brew typecheck
with your changes locally?brew tests
with your changes locally?As the remaining un-typed files were removed in #15201 and #15273, this PR enables a cop that requires files to be typed. The configuration is taken from
Sorbet/FalseSigil
above it, with the exception of excluding allHomebrew/test
files.