Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Install cached bottles if curl --head fails #15304

Conversation

boblail
Copy link
Contributor

@boblail boblail commented Apr 24, 2023

Fixes #15302

Prior to #15117, if curl --head failed for any reason, brew install would've installed previously-downloaded bottles.

If that was an unintended side-effect of #15117, then this PR restores the previous behavior.

If it was intended, is there a way to brew install a bottle from the filesystem — i.e. a no-network install provided that the given bottle matches the formula's expectations?


  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally?

Library/Homebrew/download_strategy.rb Outdated Show resolved Hide resolved
Library/Homebrew/download_strategy.rb Outdated Show resolved Hide resolved
Library/Homebrew/download_strategy.rb Outdated Show resolved Hide resolved
Copy link
Member

@MikeMcQuaid MikeMcQuaid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @boblail! A few comments.

Library/Homebrew/download_strategy.rb Outdated Show resolved Hide resolved
Fixes Homebrew#15302

Co-authored-by: Mike McQuaid <mike@mikemcquaid.com>
@boblail boblail force-pushed the lail/install-cached-bottles-if-curl---head-fails branch from 9b8efd9 to 8847719 Compare April 25, 2023 14:35
Copy link
Member

@MikeMcQuaid MikeMcQuaid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks again @boblail, another great PR!

@boblail
Copy link
Contributor Author

boblail commented Apr 25, 2023

Thanks, @MikeMcQuaid! — and thanks for the quick turn-around, as usual!

@MikeMcQuaid MikeMcQuaid merged commit 3b92bb9 into Homebrew:master Apr 25, 2023
24 checks passed
@github-actions github-actions bot added the outdated PR was locked due to age label May 26, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 26, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Installing cached bottles now requires an Internet connection after #15117
2 participants