utils/bottles: fix typechecking error #15381
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carlocab
added
the
critical
BrewTestBot
approved these changes
May 8, 2023
Bo98
approved these changes
May 8, 2023
Comment on lines
13
to
+14
| def tag(symbol = nil) | ||
| return Tag.from_symbol(symbol) if symbol.present? | ||
| return Tag.from_symbol(symbol.to_sym) if symbol.present? |
There was a problem hiding this comment.
IMO this should be fixed a level higher. The parameter is literally called "symbol" so should be a symbol.
There was a problem hiding this comment.
I thought that too (in part because I thought that might be able to fix it in one place instead of two), but I can't follow the call stack from the Sorbet error message. Happy to take a suggestion or replacement PR with a nicer fix.
This comment was marked as duplicate.
This comment was marked as duplicate.
Sorry, something went wrong.
7 tasks
carlocab
added a commit
to carlocab/brew
that referenced
this pull request
May 8, 2023
This is a better replacement of Homebrew#15381.
7 tasks
carlocab
added a commit
to carlocab/brew
that referenced
this pull request
May 8, 2023
This is a better replacement of Homebrew#15381.
carlocab
added a commit
to carlocab/brew
that referenced
this pull request
May 8, 2023
This is a better replacement of Homebrew#15381.
carlocab
added a commit
to carlocab/brew
that referenced
this pull request
May 8, 2023
This is a better replacement of Homebrew#15381.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://github.com/Homebrew/homebrew-core/actions/runs/4915420737/jobs/8777887066?pr=130438#step:5:27