Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove NoDslVersion cop. #15392

Merged
merged 1 commit into from May 10, 2023
Merged

Conversation

reitermarkus
Copy link
Member

@reitermarkus reitermarkus commented May 9, 2023

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally?

This syntax hasn't existed for ages at this point.

@reitermarkus reitermarkus force-pushed the remove-rubocop branch 2 times, most recently from 5d5ef4a to d7a315e Compare May 9, 2023 23:00
Copy link
Contributor

@apainintheneck apainintheneck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like this was added to the main brew repo in 2018 but existed before then in rubocop-cask.

commit 491ceb6c4ce05446f1b0ab73cff8a95101c7c695
Author: Mike McQuaid <mike@mikemcquaid.com>
Date:   Fri Oct 26 19:49:21 2018 +0100

    Import rubocop-cask (with clean brew style)

I agree that this probably isn't necessary anymore.

@Bo98
Copy link
Member

Bo98 commented May 10, 2023

Yeah we generally have kept these round for a while so that we can direct people to brew style --fix (like we did for bottle block syntax migration), but I agree that window of migration has probably been long exhausted so should be fine to clean up.

I'm assuming the old syntax would error in a current version of Homebrew, yes?

Copy link
Member

@MikeMcQuaid MikeMcQuaid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fine with me, thanks @reitermarkus!

@MikeMcQuaid MikeMcQuaid merged commit 04866b6 into Homebrew:master May 10, 2023
24 checks passed
@reitermarkus reitermarkus deleted the remove-rubocop branch May 10, 2023 12:29
@github-actions github-actions bot added the outdated PR was locked due to age label Jun 10, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 10, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants