Expand service paths.

[reitermarkus]

• Have you followed the guidelines in our Contributing document?
• Have you checked to ensure there aren't other open Pull Requests for the same change?
• Have you added an explanation of what your changes do and why you'd like us to include them?
• Have you written new tests for your changes? Here's an example.
• Have you successfully run brew style with your changes locally?
• Have you successfully run brew typecheck with your changes locally?
• Have you successfully run brew tests with your changes locally?

---

Allows us to replace e.g. working_dir Dir.home with working_dir "~" so we eventually don't need to stub ENV["HOME"] when generating the API anymore.

[apainintheneck]

If we're going to do this, I think we should remove it all at once.

There only seem to be a handful of instances of Dir.home in the service blocks anyway so I agree that shouldn't be necessary. We should outlaw it with Rubocop inside service blocks and stop substituting it in Service.replace_placeholders as well.

Dir.home is also used a few places in formula caveats as well as in cask artifacts neither of which need to be handled here.

I assume this is just a cleanup sort of thing or has this been causing actual bugs for users?

[reitermarkus]

All instances in casks were removed in Homebrew/homebrew-cask#147169.

I assume this is just a cleanup sort of thing or has this been causing actual bugs for users?

Just some cleanup so we eventually don't need to replace ENV["HOME"] anymore during API generation.

[MikeMcQuaid]

There only seem to be a handful of instances of Dir.home in the service blocks anyway so I agree that shouldn't be necessary. We should outlaw it with Rubocop inside service blocks and stop substituting it in Service.replace_placeholders as well.

Dir.home is also used a few places in formula caveats as well as in cask artifacts neither of which need to be handled here.

Agreed 👍🏻

[apainintheneck]

It makes sense as cleanup. I didn't see the previous PR so thanks for adding the context.