Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
brew style
with your changes locally?brew typecheck
with your changes locally?brew tests
with your changes locally?In some cases, the
Bitbucket
strategy currently matches versions from tag tarball links on a project'sdownloads/?tab=tags
page. It appears that Bitbucket now uses a hash as the filename on this page instead of the tag name, so the existing regex no longer matches.This adds an alternative regex to match versions from the tag name element (e.g.,
<td class="name">example-1.2.3</td>
), which will fix version matching in this scenario.Affected formulae are
mvnvm
,uru
,when
, andx265
. All buturu
are currently falling back to checking the Git tags from theirhead
URL. With this change, theuru
check works again and the others return to using theBitbucket
strategy (since it returns a version).For what it's worth, now that Bitbucket has dropped Mercurial support, it should be technically possible to have
Bitbucket
use theGit
strategy internally to check tags in this scenario. That may be preferable but I wanted to merge a fix in the interim time.