github_packages: create hard link instead of copying #15553
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some bottles are quite large, and the copies can make us run out of space rather quickly. Let's try to avoid that by using hard links instead of copies.
MikeMcQuaid
approved these changes
Jun 16, 2023
Is there a nice way to check for this? Sounds like it could be a conditional if it's not too complex. But it sounds like both might(?) be relative to the working directory which should mean it is always the same file system, and thus not a problem. |
Bo98
approved these changes
Jun 16, 2023
Could you elaborate on what you mean by this? Because one of my reasons for this change is that doing this doesn't change what we're uploading. That said, I did try to look at what Details
We can also check the output of However, the This should mean that nothing important has changed other than the size of the working directory. But let me know if I should be looking out for anything else.
I haven't looked, but I was thinking the same thing too.
Yes, you're right, it does look like everything happens in the current working directory so the hard links should be fine. |
As you've checked: that's more than enough for me, thanks! |
|
Thanks again @carlocab! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
brew stylewith your changes locally?brew typecheckwith your changes locally?brew testswith your changes locally?Some bottles are quite large, and the copies can make us run out of
space rather quickly. Let's try to avoid that by using hard links
instead of copies.
One case worth thinking about that I don't handle here: what if the source and destination live in different file systems?