PyPI: Handle non-pythonhosted formula URLs #15617
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 286e175.
Signed-off-by: William Woodruff <william@yossarian.net>
woodruffw
commented
Jul 3, 2023
| if main_package.valid_pypi_package? | ||
| main_package.version = version | ||
| else | ||
| return if ignore_non_pypi_packages |
There was a problem hiding this comment.
This is the only change between this PR and #15511: some callers like bump-formula-pr expect to be able to call update_python_resources! on arbitrary formulae and have it exit silently.
Signed-off-by: William Woodruff <william@yossarian.net>
|
CC @p-linnane in particular: I believe I've covered the error mode you noticed, but I'm not super familiar with the various bump workflows these days 🙂 |
Emphasize that we're failing because the user tried to update a non-PyPI package by version, when only PyPI packages can be updated by version. Other Python packages need to be updated by a full URL change. Signed-off-by: William Woodruff <william@yossarian.net>
p-linnane
approved these changes
Jul 3, 2023
There was a problem hiding this comment.
Verified that the error I was seeing last time has been resolved. LGTM, thanks @woodruffw!
…-handle-non-pypi-urls
|
CI failures here appear to be flakes. |
MikeMcQuaid
approved these changes
Jul 4, 2023
|
Thank you both! Fingers crossed on breakage this time 🙂 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
brew stylewith your changes locally?brew typecheckwith your changes locally?brew testswith your changes locally?This is take two on #15511.
From the original:
This is another quality of life improvement to our handling of Python packages, unlocked by the switch to
pip install --report --dry-runfrom a few weeks ago:pip installcan accept arbitrary distribution URLs, meaning that we no longer require the top-level to be apythonhostedURL in order to auto-bump its dependencies usingupdate-python-resources.This should result in automation for a handful of formulae that previously required manual resource updating. More indirectly, it improves
brew-pip-audit's ability to bulk audit Python packages present in Homebrew formulae, resulting in more automated vulnerability fix PRs as well.